From: Jeff King <peff@peff.net>
Date: Sat, 22 Oct 2011 19:17:14 GMT
Subject: Re: [PATCH 1/2] credential-cache--daemon.c: Don't leave stale socket on --exit
Message-ID: <20111022191711.GC1785@sigill.intra.peff.net>
In-Reply-To: <4EA2FC63.9060602@ramsay1.demon.co.uk>

On Sat, Oct 22, 2011 at 06:24:51PM +0100, Ramsay Jones wrote:

> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>  credential-cache--daemon.c |   23 ++++++++++++-----------
>  1 files changed, 12 insertions(+), 11 deletions(-)

Looks sane, and I'll probably squash it in. Alternatively, we could also
set a signal/exit handler to clean up our socket when we die. That would
also cover the error exit cases.

In either case, I think we need to handle stale sockets better. They
will happen eventually due to power loss or kill -9, anyway.

-Peff