Re: [PATCH 0/6] Towards a generalized sequencer
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Aug 12, 2011, 02:33 UTC
- Message-ID
- <20110812023323.GA672@elie.gateway.2wire.net>
- In-Reply-To
- <CALkWK0nXAU+jFwyzmYC6XuPGy8Cdmbpis0Nvb-M+tQSNk_PXiQ@mail.gmail.com>
Ramkumar Ramachandra wrote:
> 2. Should I move it to sequencer.c and and modify it accordingly? > It'll read Copyright (C) 2011 <Me>, based on builtin/revert.c which is > Copyright Dscho, which in turn is based on git-revert.sh
[...]
Isn't it still the same built-in cherry-pick code, originally by Dscho and improved over time by others? The filename is irrelevant.
If you want to add your and Christian's names to reflect multiple-cherry-pick and the restructuring, I guess that would be ok. Better yet, if you want to remove Dscho's name to encourage people to look at the commit log and get a richer story, just ask Dscho.
Asking would (1) show that you value his contribution and respect his wishes and (2) allow him to say, "no, I really prefer to keep my name there for such-and-such copyright-related reason". Of course these are only my own thoughts. Maybe I'm too picky.