git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: allow partial commits with relative paths

From
Clemens Buchacher <drizzd@aon.at>
Date
Jul 30, 2011, 17:00 UTC
Message-ID
<20110730170045.GA9900@toss.lan>
In-Reply-To
<4E343534.8000604@drmicha.warpmail.net>
On Sat, Jul 30, 2011 at 06:45:40PM +0200, Michael J Gruber wrote:
Show 5 quoted lines
> 
> > With your permission I am stealing your commit message.
> 
> I don't care about the message but don't see the point of this patch.
> Using the same message certainly won't explain the difference...
Well, to be fair I did add to your message, explaining what I did.

The point of providing a prefix at all is performance optimization. If you say there is no common prefix for the files of interest, then you cannot leave any files out and you have to read the entire tree into the index.

But even if we cannot use the working directory as a prefix, we can still figure out if there is a common prefix for all given paths, and use that instead. I merely copied that idea from ls-tree.

And considering that most of my patch the almost verbatim move of a function from one file to another, I think my change is not that big:

> >  4 files changed, 39 insertions(+), 38 deletions(-)
Clemens
Previous: Michael J GruberNext: Michael J Gruber
Message 23 of 37 in “Possible bug”
  1. Reuben ThomasJul 23, 2011
  2. commit: allow partial commits with relative pathsMichael J Gruber, Jul 25, 2011
  3. Junio C HamanoJul 25, 2011
  4. Junio C HamanoJul 25, 2011
  5. Michael J GruberJul 27, 2011
  6. Reuben ThomasJul 27, 2011
  7. Michael J GruberJul 27, 2011
  8. Reuben ThomasJul 27, 2011
  9. John SzakmeisterJul 27, 2011
  10. ls-files: fix pathspec display on errorMichael J Gruber, Jul 27, 2011
  11. Clemens BuchacherJul 29, 2011
  12. Junio C HamanoAug 1, 2011
  13. test ls-files with relative pathsClemens Buchacher, Aug 1, 2011
  14. Junio C HamanoAug 1, 2011
  15. ls-files: fix pathspec display on errorClemens Buchacher, Aug 1, 2011
  16. Junio C HamanoAug 1, 2011
  17. Erik Faye-LundJul 28, 2011
  18. Junio C HamanoJul 27, 2011
  19. Junio C HamanoJul 27, 2011
  20. Michael J GruberJul 27, 2011
  21. commit: allow partial commits with relative pathsClemens Buchacher, Jul 29, 2011
  22. Michael J GruberJul 30, 2011
  23. Clemens BuchacherJul 30, 2011
  24. Michael J GruberJul 30, 2011
  25. commit: allow partial commits with relative pathsClemens Buchacher, Jul 30, 2011
  26. Junio C HamanoAug 1, 2011
  27. Junio C HamanoAug 2, 2011
  28. Clemens BuchacherAug 3, 2011
  29. Junio C HamanoAug 3, 2011
  30. renaming pathspec_prefix (was: Re: [PATCH v2] commit: allow partial commits with relative paths)Clemens Buchacher, Sep 4, 2011
  31. 1/3 remove prefix argument from pathspec_prefixClemens Buchacher, Sep 4, 2011
  32. Junio C HamanoSep 6, 2011
  33. Junio C HamanoSep 6, 2011
  34. Clemens BuchacherSep 8, 2011
  35. Junio C HamanoSep 8, 2011
  36. 2/3 consolidate pathspec_prefix and common_prefixClemens Buchacher, Sep 4, 2011
  37. 3/3 rename pathspec_prefix -> common_prefix and move to dir.[ch]Clemens Buchacher, Sep 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.