git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN

From
AKAndi Kleen <andi@firstfloor.org>
Date
Jun 20, 2011, 22:37 UTC
Message-ID
<20110620223705.GG32765@one.firstfloor.org>
In-Reply-To
<20110620223156.GA695@elie>
> Please remember to think for yourself. ;-)  Junio generally gives good
> advice, but if you don't see the wisdom in it, that's the time to ask
> questions, not blindly do a wrong thing.
To be honest it's still not clear to me what was wrong with patch (2).
> 
> In this case, since the NO_NORETURN knob is to work around a gcc bug,
> wouldn't it make sense to add a -Wno-something-or-other option to
> BASIC_CFLAGS or COMPAT_CFLAGS when it is set?

The problem is that only relatively new gccs have options to do fine grained control on all warnings. So this would add more complications in the Makefile to check the compiler version

(I haven't checked if that's true for this particular warning, but I have run into this several times in the past for others)

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.
Previous: Jonathan NiederNext: Jonathan Nieder
Message 8 of 20 in “Add option to disable NORETURN”
  1. 1/3 Add option to disable NORETURNAndi Kleen, Jun 19, 2011
  2. 2/3 Add a lot of dummy returns to avoid warnings with NO_NORETURNAndi Kleen, Jun 19, 2011
  3. Junio C HamanoJun 20, 2011
  4. Andi KleenJun 20, 2011
  5. Junio C HamanoJun 20, 2011
  6. Andi KleenJun 20, 2011
  7. Jonathan NiederJun 20, 2011
  8. Andi KleenJun 20, 2011
  9. Jonathan NiederJun 20, 2011
  10. Jonathan NiederJun 20, 2011
  11. Andi KleenJun 21, 2011
  12. Jonathan NiederJun 21, 2011
  13. Junio C HamanoJun 20, 2011
  14. Andi KleenJun 21, 2011
  15. Junio C HamanoJun 20, 2011
  16. Andi KleenJun 20, 2011
  17. Junio C HamanoJun 20, 2011
  18. Andi KleenJun 20, 2011
  19. Junio C HamanoJun 21, 2011
  20. 3/3 Add profile feedback build to git v2Andi Kleen, Jun 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.