Re: Bug Report: git add
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Apr 10, 2011, 08:29 UTC
- Message-ID
- <20110410082916.GA31330@kytes>
- In-Reply-To
- <m31v1a4keq.fsf@localhost.localdomain>
Hi Jakub,
Jakub Narebski writes:
Show 21 quoted lines
> Ramkumar Ramachandra <artagnon@gmail.com> writes: > > Darren Cook writes: > > > > PROBLEM: "git add" adds sub-directories without checking to see if there > > > is already a git repository already there. > > > > > > WHY BAD: This causes files to be in two repositories (leading to a mess > > > if you don't notice for a while...) > > > > > > ONE SOLUTION: When adding files from a directory (except root of the > > > repository, of course) look for a .git subdirectory, and complain if > > > found. Allow --force to override this. > > > > This is a good suggestion. It already has a way to handle gitlinks > > (for submodules), so this seems like a very reasonable feature. > > I just hope that a suboptimal workflow that I use won't stop working. > > Currently I have TODO file in gitweb/ subdirectory, which is stored in > gitweb/.git repository. Still it doesn't prevent me from "git add"-ing > e.g. 'gitweb/gitweb.perl' to git repository itself.
It shouldn't. The idea is merely to make the porcelain show a friendly warning, which can be overriden with a '--force'.
-- Ram