Re: Bug Report: git add

From: Jeff King <peff@peff.net>
Date: Apr 7, 2011, 01:12 UTC
Message-ID: <20110407011240.GA4133@sigill.intra.peff.net>
In-Reply-To: <7vbp0ihnou.fsf@alter.siamese.dyndns.org>

On Wed, Apr 06, 2011 at 06:09:37PM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >>   mkdir settings
> >>   cd settings
> >>   git init
> >>   touch x
> >> ...
> >>   cd ..
> >>   git init
> >>   git add settings/
> >>    (should complain)
> >
> > If you do "git add settings" (without the slash) it will add the
> > repository as a submodule.  Which is not the behavior you asked for, but
> > is at least reasonable. So the real bug seems to me the fact that "git
> > add settings/" and "git add settings" behave differently.
> 
> Also if "git add settings/x" does not complain, that would be a bigger
> issue, whose solution would probably be in the same area.

It does not complain, and probably should. I'm unsure what "settings/" should do: produce an error as "settings/x" does (or will do, eventually, we hope), or behave as if "settings" was given.

Generally it is useful to collapse stray slashes for the user, but I wonder if there is some use to differentiate between "settings" and "the contents of the settings directory", as rsync does.

-Peff