Re: Bug Report: git add

From: Jeff King <peff@peff.net>
Date: Apr 7, 2011, 00:57 UTC
Message-ID: <20110407005750.GC28813@sigill.intra.peff.net>
In-Reply-To: <4D9BA35E.6040204@dcook.org>

On Wed, Apr 06, 2011 at 08:18:54AM +0900, Darren Cook wrote:

> PROBLEM: "git add" adds sub-directories without checking to see if there
> is already a git repository already there.

Sort of...

Show 22 quoted lines

> EXAMPLE OF PROBLEM
> 
> The problem can arise when people are just dipping their toe into git,
> and decide to try it on just one directory, then later expand its use to
> the whole project.
> 
>   mkdir test
>   cd test
> 
>   mkdir settings
>   cd settings
>   git init
>   touch x
>   git add x
>   git commit -m "xx"
> 
>   (time passes)
> 
>   cd ..
>   git init
>   git add settings/
>    (should complain)

If you do "git add settings" (without the slash) it will add the repository as a submodule. Which is not the behavior you asked for, but is at least reasonable. So the real bug seems to me the fact that "git add settings/" and "git add settings" behave differently.

-Peff