git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 2/2] git-patch-id: do not trip over "no newline" markers

From
Jeff King <peff@peff.net>
Date
Feb 18, 2011, 10:47 UTC
Message-ID
<20110218104741.GA11888@sigill.intra.peff.net>
In-Reply-To
<4D5E4D44.6000203@drmicha.warpmail.net>
On Fri, Feb 18, 2011 at 11:43:16AM +0100, Michael J Gruber wrote:
Show 10 quoted lines
> >> +		else if (!memcmp(line, "\\ ", 2) && strlen(line)>=12)
> >> +			continue;
> > 
> > Whitespace around relational operators.
> 
> You think
> 
> +		else if (!memcmp(line, "\\ ", 2)&&strlen(line)>=12)
> 
> is that much better?
Yeah, it's starting to look like perl. :)
-Peff
Previous: Michael J GruberNext: Jakub Narebski
Message 16 of 18 in “Why does git-patch-id(1) sometimes print two lines, one of which has commit = 0000000000000000000000000000000000000000”
  1. Ævar Arnfjörð BjarmasonFeb 16, 2011
  2. Michael J GruberFeb 16, 2011
  3. 1/2 git-patch-id: test for "no newline" markersMichael J Gruber, Feb 16, 2011
  4. 2/2 git-patch-id: do not trip over "no newline" markersMichael J Gruber, Feb 16, 2011
  5. Junio C HamanoFeb 16, 2011
  6. 1/2 git-patch-id: test for "no newline" markersMichael J Gruber, Feb 17, 2011
  7. Jakub NarebskiFeb 17, 2011
  8. Michael J GruberFeb 17, 2011
  9. 2/2 git-patch-id: do not trip over "no newline" markersMichael J Gruber, Feb 17, 2011
  10. Jeff KingFeb 18, 2011
  11. Michael J GruberFeb 18, 2011
  12. 1/2 git-patch-id: test for "no newline" markersMichael J Gruber, Feb 18, 2011
  13. 2/2 git-patch-id: do not trip over "no newline" markersMichael J Gruber, Feb 18, 2011
  14. Jeff KingFeb 18, 2011
  15. Michael J GruberFeb 18, 2011
  16. Jeff KingFeb 18, 2011
  17. Jakub NarebskiFeb 18, 2011
  18. Jeff KingFeb 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.