git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 1/2] git-patch-id: test for "no newline" markers

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Feb 17, 2011, 12:11 UTC
Message-ID
<4D5D108F.7060606@drmicha.warpmail.net>
In-Reply-To
<m3ei7698qf.fsf@localhost.localdomain>
Jakub Narebski venit, vidit, dixit 17.02.2011 12:55:
Show 7 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> Currently, patch-id trips over our very own diff extension for marking
>> the absence of newline at EOF.
> 
> This is not *our* diff extension; it is either GNU diff extension, or
> it is defined in diff/patch format standard.
So, which one is it?

The point is that our very own code produces that extension, so we'd better support what our "diff" and "log -p" produce.

Michael
Previous: Jakub NarebskiNext: Michael J Gruber
Message 8 of 18 in “Why does git-patch-id(1) sometimes print two lines, one of which has commit = 0000000000000000000000000000000000000000”
  1. Ævar Arnfjörð BjarmasonFeb 16, 2011
  2. Michael J GruberFeb 16, 2011
  3. 1/2 git-patch-id: test for "no newline" markersMichael J Gruber, Feb 16, 2011
  4. 2/2 git-patch-id: do not trip over "no newline" markersMichael J Gruber, Feb 16, 2011
  5. Junio C HamanoFeb 16, 2011
  6. 1/2 git-patch-id: test for "no newline" markersMichael J Gruber, Feb 17, 2011
  7. Jakub NarebskiFeb 17, 2011
  8. Michael J GruberFeb 17, 2011
  9. 2/2 git-patch-id: do not trip over "no newline" markersMichael J Gruber, Feb 17, 2011
  10. Jeff KingFeb 18, 2011
  11. Michael J GruberFeb 18, 2011
  12. 1/2 git-patch-id: test for "no newline" markersMichael J Gruber, Feb 18, 2011
  13. 2/2 git-patch-id: do not trip over "no newline" markersMichael J Gruber, Feb 18, 2011
  14. Jeff KingFeb 18, 2011
  15. Michael J GruberFeb 18, 2011
  16. Jeff KingFeb 18, 2011
  17. Jakub NarebskiFeb 18, 2011
  18. Jeff KingFeb 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.