From: Jeff King Date: Fri, 18 Feb 2011 10:47:41 GMT Subject: Re: [PATCHv3 2/2] git-patch-id: do not trip over "no newline" markers Message-ID: <20110218104741.GA11888@sigill.intra.peff.net> In-Reply-To: <4D5E4D44.6000203@drmicha.warpmail.net> On Fri, Feb 18, 2011 at 11:43:16AM +0100, Michael J Gruber wrote: > >> + else if (!memcmp(line, "\\ ", 2) && strlen(line)>=12) > >> + continue; > > > > Whitespace around relational operators. > > You think > > + else if (!memcmp(line, "\\ ", 2)&&strlen(line)>=12) > > is that much better? Yeah, it's starting to look like perl. :) -Peff