Re: a bug about format-patch of multibyte characters comment

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 13, 2011, 09:48 UTC
Message-ID: <201102131048.58111.j6t@kdbg.org>
In-Reply-To: <20110213075337.GA12112@sigill.intra.peff.net>

On Sonntag, 13. Februar 2011, Jeff King wrote:

Show 9 quoted lines

> On Sat, Feb 12, 2011 at 07:13:15PM +0900, xiaozhu wrote:
> > Subject: [PATCH]
> > =?UTF-8?q?=E6=97=A5=E6=9C=AC=E8=AA=9E=E3=81=8C=E5=A4=A7=E4=B8=88=E5=A4=AB
> > =20=E6=94=B9=E8=A1=8C=E3=81=99=E3=82=8B?=
>
> Yeah, this is wrong. There should be a whitespace indentation in a
> multi-line header, or the whole thing should be on one line. The newline
> in your commit subject is apparently leaking through, and it should be
> qp-encoded.

Isn't it wrong that format-patch (and --pretty=email) does any quoting in the first place? Isn't it the task of the MUA (git-send-email) to do the quoting?

For example, when I import a format-patch generated patch into a mail message, I don't want to see:

 From: =?UTF-8?q?Joh=C3=A4nnes=20S=C3=BCxt?= <me@localhost>

but rather:

 From: Johännes Süxt <me@localhost>

I know this is a bit late, but this really comes as a surprise. (I've never had to pay attention to this behavior in the past...)

-- Hannes