Re: a bug about format-patch of multibyte characters comment

From: Jeff King <peff@peff.net>
Date: Feb 13, 2011, 10:26 UTC
Message-ID: <20110213102627.GB7735@sigill.intra.peff.net>
In-Reply-To: <AANLkTi=Ty22nzd6ja=XmMzMu+YzDKDSBMCOGRfKenhR4@mail.gmail.com>

On Sun, Feb 13, 2011 at 07:22:14PM +0900, xzer wrote:

Show 18 quoted lines

> > A sample of rfc2047 show us a legal line broken subject mail, like
> > following:
> > ------------------------------------------------------------------
> >  Subject: =?ISO-8859-1?B?SWYgeW91IGNhbiByZWFkIHRoaXMgeW8=?=
> >    =?ISO-8859-2?B?dSB1bmRlcnN0YW5kIHRoZSBleGFtcGxlLg==?=
> > ------------------------------------------------------------------
> >
> > I understand that the current format-patch is not not valid to
> > rfc2822/rfc2047,
> > but even a valid one just like above, most of the mail client will can not
> > show it
> > correctly, they show the first line only, I think that's a problem of user
> > friendliness.
> 
> I am sorry I made a mistake, there is no problem of mail client, I just
> create a wrong format to test. So now I think if we can generate a valid
> rfc2047 patch file, and then make the am also analyze the patch file
> correctly, there is no problem. Isn't it?

Ah, OK, our mails just crossed paths. git-am already parses this correctly (actually, it is git-mailinfo that parses on behalf of git-am). We just need format-patch to generate it (and it should also probably be folding long lines in general).

-Peff