git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: a bug about format-patch of multibyte characters comment

From
Jeff King <peff@peff.net>
Date
Feb 13, 2011, 08:31 UTC
Message-ID
<20110213083137.GB12112@sigill.intra.peff.net>
In-Reply-To
<20110213075337.GA12112@sigill.intra.peff.net>
On Sun, Feb 13, 2011 at 02:53:37AM -0500, Jeff King wrote:
> No, that's not right. It breaks the use-whole-paragraph feature. The
> right fix is to encode the embedded newline in the subject properly.
Hrm. It is actually a little more complex. Right now for a subject like:
  one
  two
  three

we will convert that to the subject "one two three" for "git log --oneline" output. But for email messages, we actually return "one\n two\n three", which is conflating header folding with the actual construction of the title.

Shouldn't we still be generating "one two three", encoding it via rfc2047 if necessary, and _then_ deciding if folding is required? Yes, individual lines in a multi-line subject are good candidates for folding, but don't we need to be checking for and folding long lines anyway?

-Peff
Previous: Jeff KingNext: xiaozhu
Message 4 of 13 in “a bug about format-patch of multibyte characters comment”
  1. xiaozhuFeb 12, 2011
  2. Martin KrügerFeb 12, 2011
  3. Jeff KingFeb 13, 2011
  4. Jeff KingFeb 13, 2011
  5. xiaozhuFeb 13, 2011
  6. Jeff KingFeb 13, 2011
  7. xiaozhuFeb 13, 2011
  8. xzerFeb 13, 2011
  9. Jeff KingFeb 13, 2011
  10. xiaozhuFeb 13, 2011
  11. Jeff KingFeb 13, 2011
  12. Johannes SixtFeb 13, 2011
  13. Jeff KingFeb 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.