From: Paul Mackerras <paulus@samba.org>
Date: Tue, 18 Jan 2011 10:47:42 GMT
Subject: Re: [PATCH] gitk: Take only numeric version components when computing $git_version
Message-ID: <20110118104742.GA3279@brick.ozlabs.ibm.com>
In-Reply-To: <4D355966.7090707@debugon.org>

On Tue, Jan 18, 2011 at 10:12:06AM +0100, Mathias Lafeldt wrote:
> Jonathan Nieder wrote:
> > [...]
> > So after building from a tarball generated with "git archive", "git version"
> > produces v1.7.4-rc1, producing errors from gitk, but after building
> > from the git repo or a tarball generated with "make dist", the version
> > is v1.7.4.rc1 (which gitk accepts).
> > 
> > Anders's fix looks good to me for robustness reasons anyway, so
> > 
> >  Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> > 
> 
> OK then. Junio? :)

I'll pick it up.

Paul.