git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 5/6] msvc: opendir: handle paths ending with a slash

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 23, 2010, 17:43 UTC
Message-ID
<20101123174351.GD12113@burratino>
In-Reply-To
<1290533444-3404-6-git-send-email-kusmabite@gmail.com>
Erik Faye-Lund wrote:
Show 8 quoted lines
> --- a/compat/msvc.c
> +++ b/compat/msvc.c
> @@ -23,6 +23,8 @@ DIR *opendir(const char *name)
>  
>  	/* check that the pattern won't be too long for FindFirstFileA */
>  	len = strlen(name);
> +	if (is_dir_sep(name[len - 1]))
> +		len--;
I assume len can't be 0?
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 14 of 18 in “win32-dirent”
  1. 0/6 win32-direntErik Faye-Lund, Nov 23, 2010
  2. 1/6 msvc: opendir: use xmallocErik Faye-Lund, Nov 23, 2010
  3. Jonathan NiederNov 23, 2010
  4. Erik Faye-LundNov 23, 2010
  5. Erik Faye-LundNov 23, 2010
  6. Jonathan NiederNov 23, 2010
  7. Erik Faye-LundNov 23, 2010
  8. 2/6 msvc: opendir: allocate enough memoryErik Faye-Lund, Nov 23, 2010
  9. Jonathan NiederNov 23, 2010
  10. Erik Faye-LundNov 23, 2010
  11. 3/6 msvc: opendir: do not start the searchErik Faye-Lund, Nov 23, 2010
  12. 4/6 win32: dirent: handle errorsErik Faye-Lund, Nov 23, 2010
  13. 5/6 msvc: opendir: handle paths ending with a slashErik Faye-Lund, Nov 23, 2010
  14. Jonathan NiederNov 23, 2010
  15. Erik Faye-LundNov 23, 2010
  16. 6/6 win32: use our own dirent.hErik Faye-Lund, Nov 23, 2010
  17. Jonathan NiederNov 23, 2010
  18. Erik Faye-LundNov 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.