Re: [RFC PATCH 1/6] msvc: opendir: use xmalloc
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 23, 2010, 17:40 UTC
- Message-ID
- <20101123174050.GB12113@burratino>
- In-Reply-To
- <1290533444-3404-2-git-send-email-kusmabite@gmail.com>
Erik Faye-Lund wrote:
Show 16 quoted lines
> --- a/compat/msvc.c
> +++ b/compat/msvc.c
> @@ -7,16 +7,13 @@ DIR *opendir(const char *name)
> {
> int len;
> DIR *p;
> - p = (DIR*)malloc(sizeof(DIR));
> + p = xmalloc(sizeof(DIR));
> memset(p, 0, sizeof(DIR));
> strncpy(p->dd_name, name, PATH_MAX);
> len = strlen(p->dd_name);
> p->dd_name[len] = '/';
> p->dd_name[len+1] = '*';
>
> - if (p == NULL)
> - return NULL;A behavior change but maybe a good one. For example, the prune_packed_objects() loop currently skips object dirs it can't open, even if that is due to memory exhaustion, but this changes it to error out.
What is the motivation?