git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/6] win32-dirent

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Nov 23, 2010, 17:30 UTC
Message-ID
<1290533444-3404-1-git-send-email-kusmabite@gmail.com>

This series is against 'next', and fixes the problem on Windows introduced by commit 3ba7a06 ("A loose object is not corrupt if it cannot be read due to EMFILE").

It unifies the dirent-emulation in compat/mingw.[ch] and compat/msvc.c, giving us a custom implementation of opendir, readdir and closedir that does not incorrectly set errno to 0.

Erik Faye-Lund (6):
  msvc: opendir: use xmalloc
  msvc: opendir: allocate enough memory
  msvc: opendir: do not start the search
  win32: dirent: handle errors
  msvc: opendir: handle paths ending with a slash
  win32: use our own dirent.h
 Makefile                        |    7 ++-
 compat/mingw.c                  |   60 ------------------
 compat/mingw.h                  |   29 ---------
 compat/msvc.c                   |   29 ---------
 compat/vcbuild/include/dirent.h |  128 ---------------------------------------
 compat/win32/dirent.c           |  105 ++++++++++++++++++++++++++++++++
 compat/win32/dirent.h           |   24 +++++++
 7 files changed, 134 insertions(+), 248 deletions(-)
 delete mode 100644 compat/vcbuild/include/dirent.h
 create mode 100644 compat/win32/dirent.c
 create mode 100644 compat/win32/dirent.h
-- 
1.7.3.2.493.ge4bf7
Next: Erik Faye-Lund
Message 1 of 18 in “win32-dirent”
  1. 0/6 win32-direntErik Faye-Lund, Nov 23, 2010
  2. 1/6 msvc: opendir: use xmallocErik Faye-Lund, Nov 23, 2010
  3. Jonathan NiederNov 23, 2010
  4. Erik Faye-LundNov 23, 2010
  5. Erik Faye-LundNov 23, 2010
  6. Jonathan NiederNov 23, 2010
  7. Erik Faye-LundNov 23, 2010
  8. 2/6 msvc: opendir: allocate enough memoryErik Faye-Lund, Nov 23, 2010
  9. Jonathan NiederNov 23, 2010
  10. Erik Faye-LundNov 23, 2010
  11. 3/6 msvc: opendir: do not start the searchErik Faye-Lund, Nov 23, 2010
  12. 4/6 win32: dirent: handle errorsErik Faye-Lund, Nov 23, 2010
  13. 5/6 msvc: opendir: handle paths ending with a slashErik Faye-Lund, Nov 23, 2010
  14. Jonathan NiederNov 23, 2010
  15. Erik Faye-LundNov 23, 2010
  16. 6/6 win32: use our own dirent.hErik Faye-Lund, Nov 23, 2010
  17. Jonathan NiederNov 23, 2010
  18. Erik Faye-LundNov 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.