git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] use persistent memory for rejected paths

From
Clemens Buchacher <drizzd@aon.at>
Date
Nov 15, 2010, 23:30 UTC
Message-ID
<20101115233049.GA4782@localhost>
In-Reply-To
<7v62vyjiho.fsf@alter.siamese.dyndns.org>
On Mon, Nov 15, 2010 at 03:05:07PM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> Clemens Buchacher <drizzd@aon.at> writes:
> > You don't have to take my word for it, just try the test. It should
> > be failing nicely.  :-)
> 
> As far as I remember the tests were about the output order and never about
> "ah we are showing stale contents from stack" (which is rather hard to
> arrange for reliable testing anyway).

I changed t7607 to reject two paths 'sub' and 'sub2' and test the output. Without the fix, the output is

 error: The following untracked working tree files would be overwritten by      
 merge:                                                                         
        sub2
        sub2                                                                    
 Please move or remove them before you can merge.                               

since the same buffer is used for both rejected paths. So it does fail reliably.

Clemens
Previous: Junio C Hamano
Message 26 of 26 in “What's cooking in git.git (Nov 2010, #01; Tue, 9)”
  1. Junio C HamanoNov 9, 2010
  2. Ævar Arnfjörð BjarmasonNov 9, 2010
  3. Matthieu MoyNov 9, 2010
  4. Drew NorthupNov 9, 2010
  5. Jonathan NiederNov 9, 2010
  6. Jakub NarebskiNov 9, 2010
  7. Junio C HamanoNov 11, 2010
  8. Jakub NarebskiNov 11, 2010
  9. Johan HerlandNov 9, 2010
  10. Jeff KingNov 9, 2010
  11. Erik Faye-LundNov 9, 2010
  12. Ævar Arnfjörð BjarmasonNov 9, 2010
  13. Erik Faye-LundNov 9, 2010
  14. Ævar Arnfjörð BjarmasonNov 9, 2010
  15. Yann DirsonNov 10, 2010
  16. Nguyen Thai Ngoc DuyNov 11, 2010
  17. Nguyen Thai Ngoc DuyNov 11, 2010
  18. use persistent memory for rejected pathsClemens Buchacher, Nov 14, 2010
  19. Junio C HamanoNov 15, 2010
  20. Clemens BuchacherNov 15, 2010
  21. Matthieu MoyNov 15, 2010
  22. Clemens BuchacherNov 15, 2010
  23. use persistent memory for rejected pathsClemens Buchacher, Nov 15, 2010
  24. Matthieu MoyNov 16, 2010
  25. Junio C HamanoNov 15, 2010
  26. Clemens BuchacherNov 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.