Re: [PATCHv7 10/11] gitweb: group remote heads by remote
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Nov 11, 2010, 19:25 UTC
- Message-ID
- <201011112025.30095.jnareb@gmail.com>
- In-Reply-To
- <1289478378-15604-11-git-send-email-giuseppe.bilotta@gmail.com>
On Thu, 11 Nov 2010 at 13:26, Giuseppe Bilotta wrote:
Show 5 quoted lines
> +# Returns a hash ref mapping remote names to their fetch and push URLs. > +# We return a hash ref rather than a hash so that a simple check with defined > +# can be used to tell apart the "no remotes" case from other kinds of > +# failures. The mapping can be restriced to a single remote by specifying its > +# name as optional parameter to the call.
Errr... it is now hash or hash ref.
[...]
> +sub git_get_remotes_list {[...]
> + close $fd or return; > + return wantarray ? %remotes : \%remotes; > +}
[...]
Show 5 quoted lines
> +# Display remote heads grouped by remote, unless there are too many
> +# remotes ($have_all is false), in which case we only display the remote
> +# names
> +sub git_remotes_body {
> + my ($remotedata, $limit, $head) = @_;[...]
What $have_all?
But with exception of those out-of-date comments I like this version. Thanks.
-- Jakub Narebski Poland