git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv7 10/11] gitweb: group remote heads by remote

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 11, 2010, 19:25 UTC
Message-ID
<201011112025.30095.jnareb@gmail.com>
In-Reply-To
<1289478378-15604-11-git-send-email-giuseppe.bilotta@gmail.com>
On Thu, 11 Nov 2010 at 13:26, Giuseppe Bilotta wrote:
Show 5 quoted lines
> +# Returns a hash ref mapping remote names to their fetch and push URLs.
> +# We return a hash ref rather than a hash so that a simple check with defined
> +# can be used to tell apart the "no remotes" case from other kinds of
> +# failures. The mapping can be restriced to a single remote by specifying its
> +# name as optional parameter to the call.
Errr... it is now hash or hash ref.
[...]
> +sub git_get_remotes_list {
[...]
> +	close $fd or return;
> +	return wantarray ? %remotes : \%remotes;
> +}
[...]
Show 5 quoted lines
> +# Display remote heads grouped by remote, unless there are too many
> +# remotes ($have_all is false), in which case we only display the remote
> +# names
> +sub git_remotes_body {
> +	my ($remotedata, $limit, $head) = @_;
[...]
What $have_all?

But with exception of those out-of-date comments I like this version. Thanks.

-- 
Jakub Narebski
Poland
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 12 of 16 in “[PATCHv7 00/11] gitweb: remote_heads feature”
  1. Giuseppe BilottaNov 11, 2010
  2. 01/11 gitweb: use fullname as hash_base in heads linkGiuseppe Bilotta, Nov 11, 2010
  3. 02/11 gitweb: introduce remote_heads featureGiuseppe Bilotta, Nov 11, 2010
  4. 03/11 gitweb: git_get_heads_list accepts an optional list of refsGiuseppe Bilotta, Nov 11, 2010
  5. 04/11 gitweb: separate heads and remotes listsGiuseppe Bilotta, Nov 11, 2010
  6. 05/11 gitweb: nagivation menu for tags, heads and remotesGiuseppe Bilotta, Nov 11, 2010
  7. 06/11 gitweb: allow action specialization in page headerGiuseppe Bilotta, Nov 11, 2010
  8. 07/11 gitweb: remotes view for a single remoteGiuseppe Bilotta, Nov 11, 2010
  9. 08/11 gitweb: refactor repository URL printingGiuseppe Bilotta, Nov 11, 2010
  10. 09/11 gitweb: provide a routine to display (sub)sectionsGiuseppe Bilotta, Nov 11, 2010
  11. 10/11 gitweb: group remote heads by remoteGiuseppe Bilotta, Nov 11, 2010
  12. Jakub NarebskiNov 11, 2010
  13. 10/11 gitweb: group remote heads by remoteGiuseppe Bilotta, Nov 12, 2010
  14. 11/11 git instaweb: enable remote_headsGiuseppe Bilotta, Nov 11, 2010
  15. Jakub NarebskiNov 11, 2010
  16. Giuseppe BilottaNov 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.