git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv7 01/11] gitweb: use fullname as hash_base in heads link

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Nov 11, 2010, 12:26 UTC
Message-ID
<1289478378-15604-2-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1289478378-15604-1-git-send-email-giuseppe.bilotta@gmail.com>

Otherwise, if names are manipulated for display, the link will point to the wrong head.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 253f41a..77693ab 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4960,7 +4960,7 @@ sub git_heads_body {
 		      "<td class=\"link\">" .
 		      $cgi->a({-href => href(action=>"shortlog", hash=>$ref{'fullname'})}, "shortlog") . " | " .
 		      $cgi->a({-href => href(action=>"log", hash=>$ref{'fullname'})}, "log") . " | " .
-		      $cgi->a({-href => href(action=>"tree", hash=>$ref{'fullname'}, hash_base=>$ref{'name'})}, "tree") .
+		      $cgi->a({-href => href(action=>"tree", hash=>$ref{'fullname'}, hash_base=>$ref{'fullname'})}, "tree") .
 		      "</td>\n" .
 		      "</tr>";
 	}
-- 
1.7.3.68.g6ec8
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 2 of 16 in “[PATCHv7 00/11] gitweb: remote_heads feature”
  1. Giuseppe BilottaNov 11, 2010
  2. 01/11 gitweb: use fullname as hash_base in heads linkGiuseppe Bilotta, Nov 11, 2010
  3. 02/11 gitweb: introduce remote_heads featureGiuseppe Bilotta, Nov 11, 2010
  4. 03/11 gitweb: git_get_heads_list accepts an optional list of refsGiuseppe Bilotta, Nov 11, 2010
  5. 04/11 gitweb: separate heads and remotes listsGiuseppe Bilotta, Nov 11, 2010
  6. 05/11 gitweb: nagivation menu for tags, heads and remotesGiuseppe Bilotta, Nov 11, 2010
  7. 06/11 gitweb: allow action specialization in page headerGiuseppe Bilotta, Nov 11, 2010
  8. 07/11 gitweb: remotes view for a single remoteGiuseppe Bilotta, Nov 11, 2010
  9. 08/11 gitweb: refactor repository URL printingGiuseppe Bilotta, Nov 11, 2010
  10. 09/11 gitweb: provide a routine to display (sub)sectionsGiuseppe Bilotta, Nov 11, 2010
  11. 10/11 gitweb: group remote heads by remoteGiuseppe Bilotta, Nov 11, 2010
  12. Jakub NarebskiNov 11, 2010
  13. 10/11 gitweb: group remote heads by remoteGiuseppe Bilotta, Nov 12, 2010
  14. 11/11 git instaweb: enable remote_headsGiuseppe Bilotta, Nov 11, 2010
  15. Jakub NarebskiNov 11, 2010
  16. Giuseppe BilottaNov 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.