git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv7 04/11] gitweb: separate heads and remotes lists

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Nov 11, 2010, 12:26 UTC
Message-ID
<1289478378-15604-5-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1289478378-15604-1-git-send-email-giuseppe.bilotta@gmail.com>

We specialize the 'heads' action to only display local branches, and introduce a 'remotes' action to display the remote branches (only available when the remotes_head feature is enabled).

Mirroring this, we also split the heads list in summary view into local and remote lists, each linking to the appropriate action.

The git_get_heads_list now defaults to 'heads' only, regardless of whether the remote heads feature is active or not.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |   31 +++++++++++++++++++++++++++----
 1 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 951bb0d..9fcbbb2 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -719,6 +719,7 @@ our %actions = (
 	"log" => \&git_log,
 	"patch" => \&git_patch,
 	"patches" => \&git_patches,
+	"remotes" => \&git_remotes,
 	"rss" => \&git_rss,
 	"atom" => \&git_atom,
 	"search" => \&git_search,
@@ -3170,10 +3171,7 @@ sub parse_from_to_diffinfo {
 
 sub git_get_heads_list {
 	my ($limit, @classes) = @_;
-	unless (@classes) {
-		my $remote_heads = gitweb_check_feature('remote_heads');
-		@classes = ('heads', $remote_heads ? 'remotes' : ());
-	}
+	@classes = ('heads') unless @classes;
 	my @patterns = map { "refs/$_" } @classes;
 	my @headslist;
 
@@ -5126,6 +5124,7 @@ sub git_summary {
 	my %co = parse_commit("HEAD");
 	my %cd = %co ? parse_date($co{'committer_epoch'}, $co{'committer_tz'}) : ();
 	my $head = $co{'id'};
+	my $remote_heads = gitweb_check_feature('remote_heads');
 
 	my $owner = git_get_project_owner($project);
 
@@ -5134,6 +5133,7 @@ sub git_summary {
 	# there are more ...
 	my @taglist  = git_get_tags_list(16);
 	my @headlist = git_get_heads_list(16);
+	my @remotelist = $remote_heads ? git_get_heads_list(16, 'remotes') : ();
 	my @forklist;
 	my $check_forks = gitweb_check_feature('forks');
 
@@ -5211,6 +5211,13 @@ sub git_summary {
 		               $cgi->a({-href => href(action=>"heads")}, "..."));
 	}
 
+	if (@remotelist) {
+		git_print_header_div('remotes');
+		git_heads_body(\@remotelist, $head, 0, 15,
+		               $#remotelist <= 15 ? undef :
+		               $cgi->a({-href => href(action=>"remotes")}, "..."));
+	}
+
 	if (@forklist) {
 		git_print_header_div('forks');
 		git_project_list_body(\@forklist, 'age', 0, 15,
@@ -5525,6 +5532,22 @@ sub git_heads {
 	git_footer_html();
 }
 
+sub git_remotes {
+	gitweb_check_feature('remote_heads')
+		or die_error(403, "Remote heads view is disabled");
+
+	my $head = git_get_head_hash($project);
+	git_header_html();
+	git_print_page_nav('','', $head,undef,$head);
+	git_print_header_div('summary', $project);
+
+	my @remotelist = git_get_heads_list(undef, 'remotes');
+	if (@remotelist) {
+		git_heads_body(\@remotelist, $head);
+	}
+	git_footer_html();
+}
+
 sub git_blob_plain {
 	my $type = shift;
 	my $expires;
-- 
1.7.3.68.g6ec8
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 5 of 16 in “[PATCHv7 00/11] gitweb: remote_heads feature”
  1. Giuseppe BilottaNov 11, 2010
  2. 01/11 gitweb: use fullname as hash_base in heads linkGiuseppe Bilotta, Nov 11, 2010
  3. 02/11 gitweb: introduce remote_heads featureGiuseppe Bilotta, Nov 11, 2010
  4. 03/11 gitweb: git_get_heads_list accepts an optional list of refsGiuseppe Bilotta, Nov 11, 2010
  5. 04/11 gitweb: separate heads and remotes listsGiuseppe Bilotta, Nov 11, 2010
  6. 05/11 gitweb: nagivation menu for tags, heads and remotesGiuseppe Bilotta, Nov 11, 2010
  7. 06/11 gitweb: allow action specialization in page headerGiuseppe Bilotta, Nov 11, 2010
  8. 07/11 gitweb: remotes view for a single remoteGiuseppe Bilotta, Nov 11, 2010
  9. 08/11 gitweb: refactor repository URL printingGiuseppe Bilotta, Nov 11, 2010
  10. 09/11 gitweb: provide a routine to display (sub)sectionsGiuseppe Bilotta, Nov 11, 2010
  11. 10/11 gitweb: group remote heads by remoteGiuseppe Bilotta, Nov 11, 2010
  12. Jakub NarebskiNov 11, 2010
  13. 10/11 gitweb: group remote heads by remoteGiuseppe Bilotta, Nov 12, 2010
  14. 11/11 git instaweb: enable remote_headsGiuseppe Bilotta, Nov 11, 2010
  15. Jakub NarebskiNov 11, 2010
  16. Giuseppe BilottaNov 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.