Re: [RFC] Using gitrevisions :/search style with other operators
- From
Jeff King <peff@peff.net>
- Date
- Nov 9, 2010, 16:10 UTC
- Message-ID
- <20101109161015.GB24975@sigill.intra.peff.net>
- In-Reply-To
- <20101109083023.783fad9b@chalon.bertin.fr>
On Tue, Nov 09, 2010 at 08:30:23AM +0100, Yann Dirson wrote:
Show 8 quoted lines
> Jeff wrote:
> > It seems to me the natural way to do that would be to use our existing
> > generic "start at this ref and follow some chain" syntax, which is
> > ref^{foo}. For example: origin/pu^{:Merge 'kb/blame-author-email'}.
>
> We may want to keep the "/" mnemonic (which seems no to conflict
> withcurrent use either), rather than the ":" part, with something like
> origin/pu^{/Merge 'kb/blame-author-email'}, and keep ":" for future use.Yeah, sorry, the ':' thing was just a think-o on my part. It should definitely be "/".
Show 6 quoted lines
> > We also have ref@{upstream}. The analogue here would be
> > origin/pu@{:Merge 'kb/blame-author-email'}.
>
> That's somewhat different, it looks like the foo@{...} only applies to
> references with name "foo", and not to arbitrary revisions. Allowing a
> search to start from any commit seems more useful here.Yeah, agreed.
-Peff