Re: [RFC] Using gitrevisions :/search style with other operators

From: Yann Dirson <dirson@bertin.fr>
Date: Nov 9, 2010, 09:24 UTC
Message-ID: <20101109102428.5ba8dc13@chalon.bertin.fr>
In-Reply-To: <13A8F1B3-39B0-4D11-8763-9C458F75487D@sb.org>

On Tue, 09 Nov 2010 00:06:47 -0800 Kevin Ballard <kevin@sb.org> wrote:

Show 20 quoted lines

> On Nov 8, 2010, at 11:30 PM, Yann Dirson wrote:
> 
> > Kevin wrote:
> >> Junio wrote:
> >>>   $ git log 'HEAD..:( :/Merge branch 'kb/blame-author-email' )^2'
> > [...]
> >> 
> >> Interesting idea. It certainly solves the problem of being able to
> >> embed it within other operations (though you do then have to worry
> >> about escaping any embedded close-parens in the search), though it
> >> does mean my suggestion for being able to select the 2nd (or nth)
> >> match won't work.
> > 
> > Syntax like origin/pu^{/Merge 'kb/blame-author-email'}2 would be
> > somewhat consistent with the commit^2 case, and would seem
> > unambiguous as well - a bit weird, though.
> 
> This violates the idea that once you reach the end of a ^{} structure,
> it resolves to a commit that can then be modified by subsequent
> operations.

OK, that's kinda related to the "looks weird" issue.

Another idea: origin/pu^{:2/Merge 'kb/blame-author-email'} Since the foo^{objecttype} syntax would not care for a count, it is not a problem, and it keeps provision for using a count with future operators. OTOH, it could be a problem if we extend foo^{bar} to accept "bar" for other things than object types.

-- 
Yann Dirson - Bertin Technologies