Re: [RFC] Using gitrevisions :/search style with other operators

From: Yann Dirson <dirson@bertin.fr>
Date: Nov 9, 2010, 07:30 UTC
Message-ID: <20101109083023.783fad9b@chalon.bertin.fr>

Jeff wrote:

> It seems to me the natural way to do that would be to use our existing
> generic "start at this ref and follow some chain" syntax, which is
> ref^{foo}. For example: origin/pu^{:Merge 'kb/blame-author-email'}.

We may want to keep the "/" mnemonic (which seems no to conflict withcurrent use either), rather than the ":" part, with something like origin/pu^{/Merge 'kb/blame-author-email'}, and keep ":" for future use.

> We also have ref@{upstream}. The analogue here would be
> origin/pu@{:Merge 'kb/blame-author-email'}.

That's somewhat different, it looks like the foo@{...} only applies to references with name "foo", and not to arbitrary revisions. Allowing a search to start from any commit seems more useful here.

Kevin wrote:

> Junio wrote:
> >    $ git log 'HEAD..:( :/Merge branch 'kb/blame-author-email' )^2'

[...]

Show 6 quoted lines

>
> Interesting idea. It certainly solves the problem of being able to
> embed it within other operations (though you do then have to worry
> about escaping any embedded close-parens in the search), though it
> does mean my suggestion for being able to select the 2nd (or nth)
> match won't work.

Syntax like origin/pu^{/Merge 'kb/blame-author-email'}2 would be somewhat consistent with the commit^2 case, and would seem unambiguous as well - a bit weird, though.

-- 
Yann Dirson - Bertin Technologies