git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 8/8] Remove pack file handling dependency from wrapper.o

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 7, 2010, 18:23 UTC
Message-ID
<20101107182341.GA31470@burratino>
In-Reply-To
<4CD6CF59.5040801@lsrfire.ath.cx>
René Scharfe wrote:
> Am 06.11.2010 19:42, schrieb Jonathan Nieder:
>> Maybe add_packed_git()?
>> 
>> use_pack() is called by:
[...]
Show 5 quoted lines
>> some of which would make me worry about thread-safety.
>
> Possibly, but if that's the case then we have a thread-safety issue
> already: use_pack() updates pack_mapped, which is used by
> release_pack_memory() to see how much can be freed.
Good point.  The threaded callers are probably protected by read_lock.

My other worry would be that try_to_free_pack_memory should not override try_to_free_from_threads. I guess some time documenting these code paths will be needed. :(

Thanks for a sanity check, Jonathan

Previous: René ScharfeNext: Jonathan Nieder
Message 13 of 14 in “Remove various dependencies from wrapper.o”
  1. 0/8 Remove various dependencies from wrapper.oJonathan Nieder, Nov 6, 2010
  2. 1/8 wrapper: move xmmap() to sha1_file.cJonathan Nieder, Nov 6, 2010
  3. 2/8 wrapper: move odb_* to environment.cJonathan Nieder, Nov 6, 2010
  4. 3/8 path helpers: move git_mkstemp* to wrapper.cJonathan Nieder, Nov 6, 2010
  5. 4/8 strbuf: move strbuf_branchname to sha1_name.cJonathan Nieder, Nov 6, 2010
  6. 5/8 wrapper: give zlib wrappers their own translation unitJonathan Nieder, Nov 6, 2010
  7. 6/8 pack-objects: mark file-local variable staticJonathan Nieder, Nov 6, 2010
  8. 7/8 wrapper: expose try_to_free_pack_memory()Jonathan Nieder, Nov 6, 2010
  9. 8/8 Remove pack file handling dependency from wrapper.oJonathan Nieder, Nov 6, 2010
  10. René ScharfeNov 6, 2010
  11. Jonathan NiederNov 6, 2010
  12. René ScharfeNov 7, 2010
  13. Jonathan NiederNov 7, 2010
  14. Jonathan NiederNov 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.