Re: [PATCH 8/8] Remove pack file handling dependency from wrapper.o

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Nov 7, 2010, 16:10 UTC
Message-ID: <4CD6CF59.5040801@lsrfire.ath.cx>
In-Reply-To: <20101106184251.GA14288@burratino>

Am 06.11.2010 19:42, schrieb Jonathan Nieder:

Show 23 quoted lines

> René Scharfe wrote:
> 
>> Ugh.  Having to remember setting this handler is tedious.
>>
>> Can it be set automatically once the first pack is loaded?  A quick look
>> suggests that use_pack() would be the right place to do it.
> 
> Maybe add_packed_git()?
> 
> use_pack() is called by:
> 
>  pack-objects::check_pack_inflate
>  pack-objects::copy_pack_data
>  pack-objects::check_object
>  check_pack_crc
>  verify_pack
>  get_size_from_delta
>  sha1_file::get_delta_base
>  sha1_file::unpack_object_header
>  packed_object_info_detail
>  sha1_file::unpack_compressed_entry
> 
> some of which would make me worry about thread-safety.

Possibly, but if that's the case then we have a thread-safety issue already: use_pack() updates pack_mapped, which is used by release_pack_memory() to see how much can be freed. Just saying.

René