From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 07 Nov 2010 18:23:41 GMT
Subject: Re: [PATCH 8/8] Remove pack file handling dependency from wrapper.o
Message-ID: <20101107182341.GA31470@burratino>
In-Reply-To: <4CD6CF59.5040801@lsrfire.ath.cx>

René Scharfe wrote:
> Am 06.11.2010 19:42, schrieb Jonathan Nieder:

>> Maybe add_packed_git()?
>> 
>> use_pack() is called by:
[...]
>> some of which would make me worry about thread-safety.
>
> Possibly, but if that's the case then we have a thread-safety issue
> already: use_pack() updates pack_mapped, which is used by
> release_pack_memory() to see how much can be freed.

Good point.  The threaded callers are probably protected by read_lock.

My other worry would be that try_to_free_pack_memory should not
override try_to_free_from_threads.  I guess some time documenting
these code paths will be needed. :(

Thanks for a sanity check,
Jonathan