Re: [PATCH 6/7] t1303 (config): style tweaks

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 7, 2010, 05:27 UTC
Message-ID: <20100907052758.GQ1182@burratino>
In-Reply-To: <7vtym2p34e.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 5 quoted lines

> My gut feeling has been that any set-up that uses "git" should never be
> outside test_expect_success, but things like cat <<HERE / echo to prepare
> test vector are not expected to fail (we are not in the business of
> testing the build platform) and can be at the top of the script between
> the inclusion of test-lib.sh and the first test_expect_success.

Such a strategy sounds fine to me, for what it's worth.

(so:

	test_description=...
	. ./test-lib.sh
	cat
	...
	mkdir
	cat
	...
	cat
	...
	test_expect_success
	...
	test_expect_success
	...
	test_expect_failure
	...
	test_expect_success
	...
	test_done
)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.