git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/7] t1302 (core.repositoryversion): style tweaks

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Sep 7, 2010, 23:45 UTC
Message-ID
<AANLkTinSAqEYnrU=S9mEOztK+hVGvNNh7OQ-hHgyUwKJ@mail.gmail.com>
In-Reply-To
<20100907015227.GF1182@burratino>
2010/9/7 Jonathan Nieder <jrnieder@gmail.com>:
Show 16 quoted lines
> This test is from 2007, which is late enough for the style to be
> recognizably modern but still a while ago.  Freshen it up to
> follow new best practices:
>
>  - guard setup commands with test_expect_setup, so errors at
>   that stage can be caught;
>  - use <<\EOF in preference to <<EOF, to save reviewers the
>   trouble of looking for variable interpolations;
>  - use test_cmp instead of test "$foo" = "$bar", for better
>   output with -v on failure;
>  - indent commands in subshells and let them span multiple lines;
>  - combine the two "gitdir required mode" tests that do not make
>   as much sense alone.
>
> Cc: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Looks good to me.
-- 
Duy
Previous: Jonathan NiederNext: Jonathan Nieder
Message 12 of 27 in “Several tests: cd inside subshell instead of around”
  1. Several tests: cd inside subshell instead of aroundJens Lehmann, Sep 6, 2010
  2. Jonathan NiederSep 6, 2010
  3. Jens LehmannSep 6, 2010
  4. 0/7 Re: [PATCH] Several tests: cd inside subshell instead of aroundJonathan Nieder, Sep 7, 2010
  5. 1/7 tests: subshell indentation stylefixJonathan Nieder, Sep 7, 2010
  6. Jonathan NiederSep 7, 2010
  7. 2/7 t1450 (fsck): remove dangling objectsJonathan Nieder, Sep 7, 2010
  8. 3/7 t2105 (gitfile): add missing &&Jonathan Nieder, Sep 7, 2010
  9. Brad KingSep 7, 2010
  10. 4/7 t0004 (unwritable files): simplify error handlingJonathan Nieder, Sep 7, 2010
  11. 5/7 t1302 (core.repositoryversion): style tweaksJonathan Nieder, Sep 7, 2010
  12. Nguyen Thai Ngoc DuySep 7, 2010
  13. 6/7 t1303 (config): style tweaksJonathan Nieder, Sep 7, 2010
  14. Jeff KingSep 7, 2010
  15. Junio C HamanoSep 7, 2010
  16. Jonathan NiederSep 7, 2010
  17. guarding everything with test_expect_success (Re: [PATCH 6/7] t1303 (config): style tweaks)Jonathan Nieder, Sep 7, 2010
  18. Jeff KingSep 7, 2010
  19. Jonathan NiederSep 7, 2010
  20. 7/7 t2016 (checkout -p): use printf for multiline y/n inputJonathan Nieder, Sep 7, 2010
  21. Thomas RastSep 7, 2010
  22. Jonathan NiederSep 7, 2010
  23. Junio C HamanoSep 6, 2010
  24. Jonathan NiederSep 7, 2010
  25. Junio C HamanoSep 7, 2010
  26. Jonathan NiederSep 7, 2010
  27. t1020: Get rid of 'cd "$HERE"' at the start of each testJens Lehmann, Sep 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.