From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 07 Sep 2010 05:27:59 GMT
Subject: Re: [PATCH 6/7] t1303 (config): style tweaks
Message-ID: <20100907052758.GQ1182@burratino>
In-Reply-To: <7vtym2p34e.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> My gut feeling has been that any set-up that uses "git" should never be
> outside test_expect_success, but things like cat <<HERE / echo to prepare
> test vector are not expected to fail (we are not in the business of
> testing the build platform) and can be at the top of the script between
> the inclusion of test-lib.sh and the first test_expect_success.

Such a strategy sounds fine to me, for what it's worth.

(so:

	test_description=...
	. ./test-lib.sh
	cat
	...
	mkdir
	cat
	...
	cat
	...
	test_expect_success
	...
	test_expect_success
	...
	test_expect_failure
	...
	test_expect_success
	...
	test_done
)