Re: [bug-patch] Re: [BUG?] rename patch accepted with --dry-run, rejected without (Re: [PATCH V3] arm & sh: factorised duplicated clkdev.c)

From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Date: Sep 4, 2010, 22:01 UTC
Message-ID: <20100904220152.GB20444@n2100.arm.linux.org.uk>
In-Reply-To: <201009042346.11787.agruen@suse.de>

On Sat, Sep 04, 2010 at 11:46:11PM +0200, Andreas Gruenbacher wrote:

Show 6 quoted lines

> On Saturday 04 September 2010 23:45:27 Russell King - ARM Linux wrote:
> > It also makes them incompatible with GNU patch, whether or not GNU patch
> > understands the GIT headers.
> 
> Aha?  Then why do you think GNU patch tries to understand the GIt patch 
> headers?  So that it can be incompatible with GIT?

Read what you said last time around. "In this case, the patch itself is broken."

So, because GNU patch doesn't understand the patch file, the patch file must be broken? No, the patch file is fine with GIT which can apply it correctly, but incompatible with GNU patch because of the way GNU patch works (as you yourself said, GNU patch doesn't keep the intermediate states.)

I repeat - if you want maximum compatibility, want GNU patch to be able to apply the patch with or without --dry-run, then don't use -C or -M when generating patches with git.

Simples.