Re: [PATCH 1/3] test-lib: Add support for multiple test prerequisites

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 8, 2010, 02:03 UTC
Message-ID: <20100808020332.GA11894@burratino>
In-Reply-To: <20100808015729.GA9284@burratino>

Jonathan Nieder wrote:

Show 8 quoted lines

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -338,7 +338,7 @@ test_have_prereq () {
>  		*" $prerequisite "*)
>  			: yes, have it ;;
>  		*)
> -			! : nope ;;
> +			return 1

The ";;" is optional for the last arm in a case statement, but it is probably simpler to include it. Sorry about that.

(The only intended effect was only to use “return” that terminates and propagates out of the loop instead of “false” that is overridden by a later “true”.)