From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 08 Aug 2010 02:03:33 GMT
Subject: Re: [PATCH 1/3] test-lib: Add support for multiple test prerequisites
Message-ID: <20100808020332.GA11894@burratino>
In-Reply-To: <20100808015729.GA9284@burratino>

Jonathan Nieder wrote:

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -338,7 +338,7 @@ test_have_prereq () {
>  		*" $prerequisite "*)
>  			: yes, have it ;;
>  		*)
> -			! : nope ;;
> +			return 1

The ";;" is optional for the last arm in a case statement, but
it is probably simpler to include it.  Sorry about that.

(The only intended effect was only to use “return” that terminates and
propagates out of the loop instead of “false” that is overridden by a
later “true”.)