From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 12 Jul 2010 06:16:08 GMT
Subject: Re: [PATCH/RFC] test-lib: clean up trash* directories on SIGINT
Message-ID: <20100712061608.GA6140@burratino>
In-Reply-To: <AANLkTindliEmS2XhH8B1dUyo-v-CzpLQBqZakOaNnARW@mail.gmail.com>

Hi Ævar,

Ævar Arnfjörð Bjarmason wrote:

> Unless that's due to some unreproducable heisenbug you could get the
> trash directory by running the test with --debug.

So what should I do after noticing a heisenbug?  I guess I can suspend
with ^Z, but I would prefer not to have to train my fingers away from ^C.

> These trash directories are explicitly temporary, and
> should be cleaned up as the shell exists.

When tests learned to remove the trash directory in test_done in
v1.6.1-rc1~336^2~1 (Enable parallel tests, 2008-08-08), that was not
the rationale; it was rather to avoid too many trash directories
piling up.  If a test exits by mistake with ‘exit’ or fails with ‘-i’,
the one or two scratch directories involved are still kept for
debugging.

So you can see why a person would be reluctant to change this for
aesthetic reasons only.