git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup'

From
EWEric Wong <normalperson@yhbt.net>
Date
May 29, 2010, 02:32 UTC
Message-ID
<20100529023252.GA19705@dcvr.yhbt.net>
In-Reply-To
<1275073885-26537-4-git-send-email-jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> wrote:
> +	open my \$access_log_fh, '>', "\$logdir/access.log"
> +		or die "Couldn't open access log '\$logdir/access.log': \$!";
> +	open my \$error_log_fh,  '>', "\$logdir/error.log"
> +		or die "Couldn't open error log '\$logdir/error.log': \$!";

I believe '>>' (append) is preferable for log files and matches the behavior of all other servers. Other than that everything else looks good. I can make that change myself + Ack + push for Junio.

-- 
Eric Wong
Previous: Jakub NarebskiNext: Eric Wong
Message 7 of 9 in “git-instaweb: Support for 'plackup' and improvements”
  1. 0/3 git-instaweb: Support for 'plackup' and improvementsJakub Narebski, May 28, 2010
  2. 1/3 git-instaweb: Remove pidfile after stopping web serverJakub Narebski, May 28, 2010
  3. 2/3 git-instaweb: Wait for server to start before running web browserJakub Narebski, May 28, 2010
  4. Pavan Kumar SunkaraMay 28, 2010
  5. Jakub NarebskiMay 28, 2010
  6. 3/3 git-instaweb: Add support for running gitweb via 'plackup'Jakub Narebski, May 28, 2010
  7. Eric WongMay 29, 2010
  8. Eric WongMay 29, 2010
  9. Petr BaudisMay 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.