From: Eric Wong <normalperson@yhbt.net>
Date: Sat, 29 May 2010 02:32:52 GMT
Subject: Re: [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup'
Message-ID: <20100529023252.GA19705@dcvr.yhbt.net>
In-Reply-To: <1275073885-26537-4-git-send-email-jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> wrote:
> +	open my \$access_log_fh, '>', "\$logdir/access.log"
> +		or die "Couldn't open access log '\$logdir/access.log': \$!";
> +	open my \$error_log_fh,  '>', "\$logdir/error.log"
> +		or die "Couldn't open error log '\$logdir/error.log': \$!";

I believe '>>' (append) is preferable for log files and matches the
behavior of all other servers.  Other than that everything else looks
good.  I can make that change myself + Ack + push for Junio.

-- 
Eric Wong