Re: [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup'

From: Eric Wong <normalperson@yhbt.net>
Date: May 29, 2010, 07:21 UTC
Message-ID: <20100529072140.GA19687@dcvr.yhbt.net>
In-Reply-To: <20100529023252.GA19705@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> wrote:

Show 9 quoted lines

> Jakub Narebski <jnareb@gmail.com> wrote:
> > +	open my \$access_log_fh, '>', "\$logdir/access.log"
> > +		or die "Couldn't open access log '\$logdir/access.log': \$!";
> > +	open my \$error_log_fh,  '>', "\$logdir/error.log"
> > +		or die "Couldn't open error log '\$logdir/error.log': \$!";
> 
> I believe '>>' (append) is preferable for log files and matches the
> behavior of all other servers.  Other than that everything else looks
> good.  I can make that change myself + Ack + push for Junio.

Consider this series acked with the above change, since this series depends on changes not ready for mainline yet, I've pushed my acks to the "instaweb" branch at git://git.bogomips.org/git-svn.

-- 
Eric Wong