Re: [PATCH] http/remote-curl: coddle picky servers

From: Mike Hommey <mh@glandium.org>
Date: Jan 21, 2010, 16:07 UTC
Message-ID: <20100121160707.GA31276@glandium.org>
In-Reply-To: <20100121155637.GA19078@spearce.org>

On Thu, Jan 21, 2010 at 07:56:37AM -0800, Shawn O. Pearce wrote:

Show 13 quoted lines

> Tay Ray Chuan <rctay89@gmail.com> wrote:
> > When "info/refs" is a static file and not behind a CGI handler, some
> > servers may not handle a GET request for it with a query string
> > appended (eg. "?foo=bar") properly.
> > 
> > If such a request fails, retry it sans the query string. In addition,
> > ensure that the "smart" http protocol is not used (a service has to be
> > specified with "?service=<service name>" to be conformant).
> > 
> > Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
> > Reported-and-tested-by: Yaroslav Halchenko <debian@onerussian.com>
> 
> *grumble* stupid Apache *grumble*

stupid Apache... configuration.

Check the error message you get on http://git.debian.org/git/pkg-exppsy/pymvpa.git/info/refs?service=git-upload-pack:

The requested URL /gitweb.cgigit/pkg-exppsy/pymvpa.git/info/refs was not found on this server.

Look closely at the start of the requested URL: /gitweb.cgi... It comes from this rule:

RewriteCond %{QUERY_STRING} ^(.+)$ RewriteRule ^/(.*)$ /gitweb.cgi$1 [L,PT]

which is global to the virtual host.

Anyways, while git.debian.org can certainly be fixed for that, other servers may want to do some different things with urls with parameters.

Mike