git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: honor NO_CURL when setting REMOTE_CURL_* variables

From
ILIlari Liusvaara <ilari.liusvaara@elisanet.fi>
Date
Jan 19, 2010, 16:58 UTC
Message-ID
<20100119165858.GA24065@Knoppix>
In-Reply-To
<1263915552-32537-1-git-send-email-j6t@kdbg.org>
On Tue, Jan 19, 2010 at 04:39:12PM +0100, Johannes Sixt wrote:
Show 7 quoted lines
> Previously, these variables were set before there was a chance to set
> NO_CURL.
> 
> This made a difference only during 'make install', because by installing
> $(REMOTE_CURL_ALIASES), the rule  tries to access $(REMOTE_CURL_PRIMARY),
> which was never installed. On Windows, this fails; on Unix, stale symbolic
> links are created.
 
<snip patch>

I didn't even compile-test it, but based on quick look I don't see any obivous mistakes. There are no references to REMOTE_CURL_* in section moved over, and the variable values should not differ unless section skipped sets NO_CURL. So:

Acked-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
-Ilari
Previous: Johannes SixtNext: Junio C Hamano
Message 2 of 3 in “Makefile: honor NO_CURL when setting REMOTE_CURL_* variables”
  1. Makefile: honor NO_CURL when setting REMOTE_CURL_* variablesJohannes Sixt, Jan 19, 2010
  2. Ilari LiusvaaraJan 19, 2010
  3. Junio C HamanoJan 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.