From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Tue, 19 Jan 2010 16:58:58 GMT
Subject: Re: [PATCH] Makefile: honor NO_CURL when setting REMOTE_CURL_* variables
Message-ID: <20100119165858.GA24065@Knoppix>
In-Reply-To: <1263915552-32537-1-git-send-email-j6t@kdbg.org>

On Tue, Jan 19, 2010 at 04:39:12PM +0100, Johannes Sixt wrote:
> Previously, these variables were set before there was a chance to set
> NO_CURL.
> 
> This made a difference only during 'make install', because by installing
> $(REMOTE_CURL_ALIASES), the rule  tries to access $(REMOTE_CURL_PRIMARY),
> which was never installed. On Windows, this fails; on Unix, stale symbolic
> links are created.
 
<snip patch>

I didn't even compile-test it, but based on quick look I don't see any
obivous mistakes. There are no references to REMOTE_CURL_* in section
moved over, and the variable values should not differ unless section skipped
sets NO_CURL. So:

Acked-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>

-Ilari