Re: [PATCH] Makefile: honor NO_CURL when setting REMOTE_CURL_* variables

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 19, 2010, 23:31 UTC
Message-ID: <7vockp7jtj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100119165858.GA24065@Knoppix>

Ilari Liusvaara <ilari.liusvaara@elisanet.fi> writes:

Show 19 quoted lines

> On Tue, Jan 19, 2010 at 04:39:12PM +0100, Johannes Sixt wrote:
>> Previously, these variables were set before there was a chance to set
>> NO_CURL.
>> 
>> This made a difference only during 'make install', because by installing
>> $(REMOTE_CURL_ALIASES), the rule  tries to access $(REMOTE_CURL_PRIMARY),
>> which was never installed. On Windows, this fails; on Unix, stale symbolic
>> links are created.
>  
> <snip patch>
>
> I didn't even compile-test it, but based on quick look I don't see any
> obivous mistakes. There are no references to REMOTE_CURL_* in section
> moved over, and the variable values should not differ unless section skipped
> sets NO_CURL. So:
>
> Acked-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
>
> -Ilari

Thanks.