git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: match explicit-ident semantics for summary and template

From
Johannes Sixt <j6t@kdbg.org>
Date
Jan 17, 2010, 20:53 UTC
Message-ID
<201001172153.44413.j6t@kdbg.org>
In-Reply-To
<20100117193401.GA28448@coredump.intra.peff.net>
On Sonntag, 17. Januar 2010, Jeff King wrote:
> -	if (!user_ident_explicitly_given) {
> +	if (user_ident_explicitly_given != IDENT_ALL_GIVEN) {
>  		strbuf_addstr(&format, "\n Committer: ");

Sorry for chiming in so late, but this new condition worries me a bit. On all of my machines I have the GECOS field filled in with "Johannes Sixt", i.e., I do not need user.name. But of course the automatically derived email address is nonsense, so I've set up only user.email. Now I would always this hint, wouldn't I? Do most others fill in GECOS in ways that are inappropriate for git?

-- Hannes
Previous: Jeff KingNext: Jeff King
Message 2 of 6 in “commit: match explicit-ident semantics for summary and template”
  1. commit: match explicit-ident semantics for summary and templateJeff King, Jan 17, 2010
  2. Johannes SixtJan 17, 2010
  3. Jeff KingJan 17, 2010
  4. Junio C HamanoJan 17, 2010
  5. Jeff KingJan 18, 2010
  6. Junio C HamanoJan 18, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.