From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 17 Jan 2010 20:53:44 GMT
Subject: Re: [PATCH] commit: match explicit-ident semantics for summary and template
Message-ID: <201001172153.44413.j6t@kdbg.org>
In-Reply-To: <20100117193401.GA28448@coredump.intra.peff.net>

On Sonntag, 17. Januar 2010, Jeff King wrote:
> -	if (!user_ident_explicitly_given) {
> +	if (user_ident_explicitly_given != IDENT_ALL_GIVEN) {
>  		strbuf_addstr(&format, "\n Committer: ");

Sorry for chiming in so late, but this new condition worries me a bit. On all 
of my machines I have the GECOS field filled in with "Johannes Sixt", i.e., I 
do not need user.name. But of course the automatically derived email address 
is nonsense, so I've set up only user.email. Now I would always this hint, 
wouldn't I? Do most others fill in GECOS in ways that are inappropriate for 
git?

-- Hannes