git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] build dashless "test-bin" directory similar to installed bindir

From
Jeff King <peff@peff.net>
Date
Nov 29, 2009, 03:43 UTC
Message-ID
<20091129034313.GA28379@coredump.intra.peff.net>
In-Reply-To
<7vaay6f4ce.fsf@alter.siamese.dyndns.org>
On Sat, Nov 28, 2009 at 06:32:33PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> > Would implementing it that way mean that:
> >
> >   make && cd t && make
> >
> > does not work (or worse, might silently use stale information in
> > test-bin)?
> 
> Why can't t/Makefile have a dependency on its 'default' target that goes
> up and prepares test-bin/, i.e. "cd .. && make test-bin-stuff"?

Yeah, that would work (I really should have phrased my other response less as a critique and more as "please don't break this workflow"). But I don't think the default target would be enough. I would also expect

  make && cd t && make tXXXX-YYYY.sh

to work correctly (and to be pedantic, I am actually more interested in the equivalent situation that one has one window looking at code and compiling, and another window running a test script, but they are functionally equivalent here).

I also like to be able to simply run ./tXXXX-YYYY.sh. I can accept losing that if there is something to be gained, but if we can keep it, I suspect I am not the only one who uses it.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 14 in “Run test suite without dashed commands in PATH”
  1. 0/4 Run test suite without dashed commands in PATHMatthew Ogilvie, Nov 28, 2009
  2. 1/4 t2300: use documented technique to invoke git-sh-setupMatthew Ogilvie, Nov 28, 2009
  3. 2/4 t3409 t4107 t7406: use dashless commandsMatthew Ogilvie, Nov 28, 2009
  4. 3/4 build dashless "test-bin" directory similar to installed bindirMatthew Ogilvie, Nov 28, 2009
  5. 4/4 run test suite without dashed git-commands in PATHMatthew Ogilvie, Nov 28, 2009
  6. Junio C HamanoNov 28, 2009
  7. Jeff KingNov 28, 2009
  8. Junio C HamanoNov 29, 2009
  9. Jeff KingNov 29, 2009
  10. Junio C HamanoNov 29, 2009
  11. Jeff KingNov 29, 2009
  12. Matthew OgilvieNov 29, 2009
  13. Matthew OgilvieNov 29, 2009
  14. Nanako ShiraishiNov 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.