From: Jeff King <peff@peff.net>
Date: Sun, 29 Nov 2009 03:43:13 GMT
Subject: Re: [PATCH 3/4] build dashless "test-bin" directory similar to installed bindir
Message-ID: <20091129034313.GA28379@coredump.intra.peff.net>
In-Reply-To: <7vaay6f4ce.fsf@alter.siamese.dyndns.org>

On Sat, Nov 28, 2009 at 06:32:33PM -0800, Junio C Hamano wrote:

> > Would implementing it that way mean that:
> >
> >   make && cd t && make
> >
> > does not work (or worse, might silently use stale information in
> > test-bin)?
> 
> Why can't t/Makefile have a dependency on its 'default' target that goes
> up and prepares test-bin/, i.e. "cd .. && make test-bin-stuff"?

Yeah, that would work (I really should have phrased my other response
less as a critique and more as "please don't break this workflow"). But
I don't think the default target would be enough. I would also expect

  make && cd t && make tXXXX-YYYY.sh

to work correctly (and to be pedantic, I am actually more interested in
the equivalent situation that one has one window looking at code and
compiling, and another window running a test script, but they are
functionally equivalent here).

I also like to be able to simply run ./tXXXX-YYYY.sh. I can accept
losing that if there is something to be gained, but if we can keep it, I
suspect I am not the only one who uses it.

-Peff