git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] build dashless "test-bin" directory similar to installed bindir

From
MOMatthew Ogilvie <mmogilvi_git@miniinfo.net>
Date
Nov 29, 2009, 04:23 UTC
Message-ID
<20091129042355.GA2252@comcast.net>
In-Reply-To
<7vaay6f4ce.fsf@alter.siamese.dyndns.org>
On Sat, Nov 28, 2009 at 06:32:33PM -0800, Junio C Hamano wrote:
> Why can't t/Makefile have a dependency on its 'default' target that goes
> up and prepares test-bin/, i.e. "cd .. && make test-bin-stuff"?

That wouldn't help with someone manually running specific tests, which is a common way to run tests when working on git:

   hackhackhack && make && cd t && ./tXXXX-*.sh

Perhaps we could invoke make from test-lib.sh, but at that point it starts to look more attractive to just do it the same way as the valgrind option, even though that means duplicating the appropriate list of executables in test-lib.sh.

Also, "make all" already builds some test suite support binaries (test-*). Is it really worth any effort to leave a few short wrapper scripts out of "make all" when it is already building several test binaries?

(See also my much longer email response that crossed this one in the mail.)

-- Matthew Ogilvie [mmogilvi_git@miniinfo.net]

Previous: Jeff KingNext: Matthew Ogilvie
Message 12 of 14 in “Run test suite without dashed commands in PATH”
  1. 0/4 Run test suite without dashed commands in PATHMatthew Ogilvie, Nov 28, 2009
  2. 1/4 t2300: use documented technique to invoke git-sh-setupMatthew Ogilvie, Nov 28, 2009
  3. 2/4 t3409 t4107 t7406: use dashless commandsMatthew Ogilvie, Nov 28, 2009
  4. 3/4 build dashless "test-bin" directory similar to installed bindirMatthew Ogilvie, Nov 28, 2009
  5. 4/4 run test suite without dashed git-commands in PATHMatthew Ogilvie, Nov 28, 2009
  6. Junio C HamanoNov 28, 2009
  7. Jeff KingNov 28, 2009
  8. Junio C HamanoNov 29, 2009
  9. Jeff KingNov 29, 2009
  10. Junio C HamanoNov 29, 2009
  11. Jeff KingNov 29, 2009
  12. Matthew OgilvieNov 29, 2009
  13. Matthew OgilvieNov 29, 2009
  14. Nanako ShiraishiNov 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.