Re: [msysGit] [PATCH/RFC 03/11] mingw: implement syslog

From: Johannes Sixt <j6t@kdbg.org>
Date: Nov 27, 2009, 19:23 UTC
Message-ID: <200911272023.58262.j6t@kdbg.org>
In-Reply-To: <40aa078e0911270009u7569cfe5gb250092c8d2c0eac@mail.gmail.com>

On Freitag, 27. November 2009, Erik Faye-Lund wrote:

Show 18 quoted lines

> On Thu, Nov 26, 2009 at 10:23 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> > I would
> >
> >        const char* arg;
> >        if (strcmp(fmt, "%s"))
> >                die("format string of syslog() not implemented")
> >        va_start(va, fmt);
> >        arg = va_arg(va, char*);
> >        va_end(va);
> >
> > because we have exactly one invocation of syslog(), which passes "%s" as
> > format string. Then strbuf_vaddf is not needed. Or even simpler: declare
> > the function as
> >
> > void syslog(int priority, const char *fmt, const char*arg);
>
> After reading this again, I agree that this is the best solution. I'll
> update for the next iteration.

Except that you shouldn't die like I proposed because here we are already in the die_routine, no?

Show 9 quoted lines

> > "Note that the string that you log cannot contain %n, where n is an
> > integer value (for example, %1) because the event viewer treats it as an
> > insertion string. ..."
> >
> > How are the chances that this condition applies to our use of the
> > function?
>
> Ugh, increasingly high since we're adding IPv6 support, I guess.
> Perhaps some form of escaping needs to be done?

I think so, but actually I have no clue.

-- Hannes