git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] [PATCH/RFC 07/11] run-command: support input-fd

From
Johannes Sixt <j6t@kdbg.org>
Date
Nov 26, 2009, 21:53 UTC
Message-ID
<200911262253.59641.j6t@kdbg.org>
In-Reply-To
<1259196260-3064-8-git-send-email-kusmabite@gmail.com>
On Donnerstag, 26. November 2009, Erik Faye-Lund wrote:
Show 27 quoted lines
> This patch adds the possibility to supply a non-0
> file descriptor for communucation, instead of the
> default-created pipe. The pipe gets duplicated, so
> the caller can free it's handles.
>
> This is usefull for async communication over sockets.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>  run-command.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/run-command.c b/run-command.c
> index e5a0e06..98771ef 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -327,7 +327,10 @@ int start_async(struct async *async)
>  {
>  	int pipe_out[2];
>
> -	if (pipe(pipe_out) < 0)
> +	if (async->out) {
> +		pipe_out[0] = dup(async->out);
> +		pipe_out[1] = dup(async->out);
> +	} else if (pipe(pipe_out) < 0)
>  		return error("cannot create pipe: %s", strerror(errno));
>  	async->out = pipe_out[0];
Hm. If async->out != 0:
	pipe_out[0] = dup(async->out);
	async->out = pipe_out[0];
This is confusing.

Moreover, you are assigning (a dup of) the same fd to the writable end. This assumes a bi-directional channel. I don't yet know what I should think about this (haven't studied the later patches, yet).

It would be great if you could add a few words to Documentation/technical/api-runcommand.txt.

-- Hannes
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 24 of 54 in “daemon-win32”
  1. 00/11 daemon-win32Erik Faye-Lund, Nov 26, 2009
  2. 01/11 mingw: add network-wrappers for daemonErik Faye-Lund, Nov 26, 2009
  3. 02/11 strbuf: add non-variadic function strbuf_vaddf()Erik Faye-Lund, Nov 26, 2009
  4. 03/11 mingw: implement syslogErik Faye-Lund, Nov 26, 2009
  5. 04/11 compat: add inet_pton and inet_ntop prototypesErik Faye-Lund, Nov 26, 2009
  6. 05/11 inet_ntop: fix a couple of old-style declsErik Faye-Lund, Nov 26, 2009
  7. 06/11 run-command: add kill_async() and is_async_alive()Erik Faye-Lund, Nov 26, 2009
  8. 07/11 run-command: support input-fdErik Faye-Lund, Nov 26, 2009
  9. 08/11 daemon: use explicit file descriptorErik Faye-Lund, Nov 26, 2009
  10. 09/11 daemon: use run-command api for async servingErik Faye-Lund, Nov 26, 2009
  11. 10/11 daemon: use full buffered mode for stderrErik Faye-Lund, Nov 26, 2009
  12. 11/11 mingw: compile git-daemonErik Faye-Lund, Nov 26, 2009
  13. Johannes SixtNov 27, 2009
  14. Johannes SixtNov 27, 2009
  15. Erik Faye-LundDec 2, 2009
  16. Johannes SixtDec 2, 2009
  17. Erik Faye-LundDec 8, 2009
  18. Johannes SixtNov 26, 2009
  19. Erik Faye-LundNov 27, 2009
  20. Erik Faye-LundNov 27, 2009
  21. Johannes SixtNov 27, 2009
  22. Johannes SixtNov 27, 2009
  23. Erik Faye-LundDec 8, 2009
  24. Johannes SixtNov 26, 2009
  25. Erik Faye-LundNov 27, 2009
  26. Johannes SixtNov 27, 2009
  27. Erik Faye-LundDec 8, 2009
  28. Johannes SixtNov 26, 2009
  29. Erik Faye-LundNov 27, 2009
  30. Johannes SixtNov 27, 2009
  31. Erik Faye-LundDec 2, 2009
  32. Johannes SixtDec 2, 2009
  33. Erik Faye-LundJan 9, 2010
  34. Erik Faye-LundJan 10, 2010
  35. Johannes SixtNov 26, 2009
  36. Erik Faye-LundNov 27, 2009
  37. Johannes SixtNov 27, 2009
  38. Erik Faye-LundDec 8, 2009
  39. Junio C HamanoNov 26, 2009
  40. Erik Faye-LundNov 26, 2009
  41. Paolo BonziniNov 26, 2009
  42. Junio C HamanoNov 26, 2009
  43. Erik Faye-LundNov 26, 2009
  44. Johannes SixtNov 27, 2009
  45. Martin StorsjöNov 26, 2009
  46. Improve the mingw getaddrinfo stub to handle more use casesMartin Storsjö, Nov 26, 2009
  47. Erik Faye-LundNov 26, 2009
  48. Martin StorsjöNov 26, 2009
  49. Erik Faye-LundDec 2, 2009
  50. Martin StorsjöDec 2, 2009
  51. Erik Faye-LundDec 2, 2009
  52. Erik Faye-LundDec 2, 2009
  53. Johannes SixtDec 2, 2009
  54. Johannes SixtNov 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.