git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 04/11] compat: add inet_pton and inet_ntop prototypes

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Nov 26, 2009, 00:44 UTC
Message-ID
<1259196260-3064-5-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1259196260-3064-4-git-send-email-kusmabite@gmail.com>
From: Mike Pape <dotzenlabs@gmail.com>

Windows doesn't have inet_pton and inet_ntop, so add prototypes in git-compat-util.h for them.

At the same time include git-compat-util.h in the sources for these functions, so they use the network-wrappers from there on Windows.

Signed-off-by: Mike Pape <dotzenlabs@gmail.com>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 Makefile           |    2 ++
 compat/inet_ntop.c |    6 +++---
 compat/inet_pton.c |    8 +++++---
 git-compat-util.h  |    8 ++++++++
 4 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 70cee6d..3b01694 100644
--- a/Makefile
+++ b/Makefile
@@ -1227,9 +1227,11 @@ endif
 endif
 ifdef NO_INET_NTOP
 	LIB_OBJS += compat/inet_ntop.o
+	BASIC_CFLAGS += -DNO_INET_NTOP
 endif
 ifdef NO_INET_PTON
 	LIB_OBJS += compat/inet_pton.o
+	BASIC_CFLAGS += -DNO_INET_PTON
 endif
 
 ifdef NO_ICONV
diff --git a/compat/inet_ntop.c b/compat/inet_ntop.c
index f444982..e5b46a0 100644
--- a/compat/inet_ntop.c
+++ b/compat/inet_ntop.c
@@ -17,9 +17,9 @@
 
 #include <errno.h>
 #include <sys/types.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-#include <arpa/inet.h>
+
+#include "../git-compat-util.h"
+
 #include <stdio.h>
 #include <string.h>
 
diff --git a/compat/inet_pton.c b/compat/inet_pton.c
index 4078fc0..2ec995e 100644
--- a/compat/inet_pton.c
+++ b/compat/inet_pton.c
@@ -17,9 +17,9 @@
 
 #include <errno.h>
 #include <sys/types.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-#include <arpa/inet.h>
+
+#include "../git-compat-util.h"
+
 #include <stdio.h>
 #include <string.h>
 
@@ -41,7 +41,9 @@
  */
 
 static int inet_pton4(const char *src, unsigned char *dst);
+#ifndef NO_IPV6
 static int inet_pton6(const char *src, unsigned char *dst);
+#endif
 
 /* int
  * inet_pton4(src, dst)
diff --git a/git-compat-util.h b/git-compat-util.h
index 33a8e33..27fa601 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -340,6 +340,14 @@ static inline char *gitstrchrnul(const char *s, int c)
 }
 #endif
 
+#ifdef NO_INET_PTON
+int inet_pton(int af, const char *src, void *dst);
+#endif
+
+#ifdef NO_INET_NTOP
+const char *inet_ntop(int af, const void *src, char *dst, size_t size);
+#endif
+
 extern void release_pack_memory(size_t, int);
 
 extern char *xstrdup(const char *str);
-- 
1.6.5.rc2.7.g4f8d3
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 5 of 54 in “daemon-win32”
  1. 00/11 daemon-win32Erik Faye-Lund, Nov 26, 2009
  2. 01/11 mingw: add network-wrappers for daemonErik Faye-Lund, Nov 26, 2009
  3. 02/11 strbuf: add non-variadic function strbuf_vaddf()Erik Faye-Lund, Nov 26, 2009
  4. 03/11 mingw: implement syslogErik Faye-Lund, Nov 26, 2009
  5. 04/11 compat: add inet_pton and inet_ntop prototypesErik Faye-Lund, Nov 26, 2009
  6. 05/11 inet_ntop: fix a couple of old-style declsErik Faye-Lund, Nov 26, 2009
  7. 06/11 run-command: add kill_async() and is_async_alive()Erik Faye-Lund, Nov 26, 2009
  8. 07/11 run-command: support input-fdErik Faye-Lund, Nov 26, 2009
  9. 08/11 daemon: use explicit file descriptorErik Faye-Lund, Nov 26, 2009
  10. 09/11 daemon: use run-command api for async servingErik Faye-Lund, Nov 26, 2009
  11. 10/11 daemon: use full buffered mode for stderrErik Faye-Lund, Nov 26, 2009
  12. 11/11 mingw: compile git-daemonErik Faye-Lund, Nov 26, 2009
  13. Johannes SixtNov 27, 2009
  14. Johannes SixtNov 27, 2009
  15. Erik Faye-LundDec 2, 2009
  16. Johannes SixtDec 2, 2009
  17. Erik Faye-LundDec 8, 2009
  18. Johannes SixtNov 26, 2009
  19. Erik Faye-LundNov 27, 2009
  20. Erik Faye-LundNov 27, 2009
  21. Johannes SixtNov 27, 2009
  22. Johannes SixtNov 27, 2009
  23. Erik Faye-LundDec 8, 2009
  24. Johannes SixtNov 26, 2009
  25. Erik Faye-LundNov 27, 2009
  26. Johannes SixtNov 27, 2009
  27. Erik Faye-LundDec 8, 2009
  28. Johannes SixtNov 26, 2009
  29. Erik Faye-LundNov 27, 2009
  30. Johannes SixtNov 27, 2009
  31. Erik Faye-LundDec 2, 2009
  32. Johannes SixtDec 2, 2009
  33. Erik Faye-LundJan 9, 2010
  34. Erik Faye-LundJan 10, 2010
  35. Johannes SixtNov 26, 2009
  36. Erik Faye-LundNov 27, 2009
  37. Johannes SixtNov 27, 2009
  38. Erik Faye-LundDec 8, 2009
  39. Junio C HamanoNov 26, 2009
  40. Erik Faye-LundNov 26, 2009
  41. Paolo BonziniNov 26, 2009
  42. Junio C HamanoNov 26, 2009
  43. Erik Faye-LundNov 26, 2009
  44. Johannes SixtNov 27, 2009
  45. Martin StorsjöNov 26, 2009
  46. Improve the mingw getaddrinfo stub to handle more use casesMartin Storsjö, Nov 26, 2009
  47. Erik Faye-LundNov 26, 2009
  48. Martin StorsjöNov 26, 2009
  49. Erik Faye-LundDec 2, 2009
  50. Martin StorsjöDec 2, 2009
  51. Erik Faye-LundDec 2, 2009
  52. Erik Faye-LundDec 2, 2009
  53. Johannes SixtDec 2, 2009
  54. Johannes SixtNov 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.