git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] gitweb: Refactor 'log' action generation, adding git_log_body()

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 13, 2009, 23:59 UTC
Message-ID
<200911140059.08084.jnareb@gmail.com>
In-Reply-To
<20091114081050.6117@nanako3.lavabit.com>
On Sat, 14 Nov 2009, Nanako Shiraishi wrote:
Show 14 quoted lines
> Quoting Jakub Narebski <jnareb@gmail.com>
> 
> > Put the main part of 'log' view generation into git_log_body,
> > similarly how it is done for 'shortlog' and 'history' views (and
> > also for 'tags' and 'heads' views).
> >
> > This is preparation for extracting common code between 'log',
> > 'shortlog' and 'history' actions.
> >
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> > ---
> > This is pure refactoring: output should change.
> 
> Did you mean "should not change"?

Yes, of course, it should be "output should not change" (as opposed to later patches, which unify not only code but some of looks).

-- 
Jakub Narebski
Poland
Previous: Nanako ShiraishiNext: Jakub Narebski
Message 4 of 6 in “gitweb: Refactor common parts of log-like views”
  1. 0/3 gitweb: Refactor common parts of log-like viewsJakub Narebski, Nov 13, 2009
  2. 1/3 gitweb: Refactor 'log' action generation, adding git_log_body()Jakub Narebski, Nov 13, 2009
  3. Nanako ShiraishiNov 13, 2009
  4. Jakub NarebskiNov 13, 2009
  5. 2/3 gitweb: Refactor common parts of 'log' and 'shortlog' viewsJakub Narebski, Nov 13, 2009
  6. 3/3 gitweb: Make 'history' view (re)use git_log_generic()Jakub Narebski, Nov 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.